Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tween.sequence #16168

Closed
wants to merge 2 commits into from
Closed

fix tween.sequence #16168

wants to merge 2 commits into from

Conversation

zxx43
Copy link
Contributor

@zxx43 zxx43 commented Sep 1, 2023

Re: #

Changelog

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

fix issue: https://github.com/cocos/3d-tasks/issues/17561

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Interface Check Report

This pull request does not change any public interfaces !

@qiuguohua qiuguohua requested a review from minggo October 26, 2023 23:57
@minggo minggo requested a review from qiuguohua October 27, 2023 01:10
qiuguohua
qiuguohua approved these changes Oct 27, 2023
View reviewed changes
cocos/tween/actions/action-interval.ts
errorID(1019);
return null as any;
// errorID(1019);
// return null as any;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comments?

@qiuguohua qiuguohua mentioned this pull request Oct 27, 2023
Merged
6 tasks
@qiuguohua
Copy link
Contributor

#16443

@qiuguohua qiuguohua closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiuguohua qiuguohua qiuguohua approved these changes

@minggo minggo Awaiting requested review from minggo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxx43 @qiuguohua